Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): improve and refactor get all albums #2048

Merged
merged 2 commits into from
Mar 26, 2023

Conversation

michelheusschen
Copy link
Contributor

Continuation of #1937 to improve the performance of the /api/album endpoint. Used default TypeORM functions instead of the query builder where possible. Although I originally planned to refactor the entire album repo, I decided against it because it would make tracking changes more difficult.

  • Improved listing albums performance. Listing 20 albums with 5000 assets each (100.000 assets total) now takes less than 50ms (before >2s)
  • Fix bug where /api/album?shared=false would include albums with shared links
  • Better validation for query paramters
  • Extended album E2E tests
  • Refactored to using domain/infra
  • Refactored updating thumbnails

@vercel
Copy link

vercel bot commented Mar 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
immich ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 25, 2023 at 3:18PM (UTC)

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code all looks good. Great job! This is a lot of core functionality that's being touched, so we should make sure to test it as much as possible. I'll try to spin it up later today.

@alextran1502 alextran1502 merged commit c74fba4 into main Mar 26, 2023
@alextran1502 alextran1502 deleted the feat/server-list-albums branch March 26, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants