Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mobile): migrate all Hive boxes to Isar database #2036

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

fyfrey
Copy link
Contributor

@fyfrey fyfrey commented Mar 21, 2023

This PR removes all Hive usage across the mobile app and replaces it with the custom Store class.
The Store is now also type-safe.

Migrations for existing Hive boxes are performed once on app start. After successful migration, the Hive boxes are removed.

We can delete the (generated) Hive classes and migration once enough releases have passed (so that users had a chance to update).

@vercel
Copy link

vercel bot commented Mar 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
immich ⬜️ Ignored (Inspect) Mar 22, 2023 at 4:45PM (UTC)

@fyfrey fyfrey force-pushed the dev/migrate-all-hive-boxes-to-isar branch from 8a0cf41 to 193ca00 Compare March 21, 2023 10:56
@fyfrey fyfrey force-pushed the dev/migrate-all-hive-boxes-to-isar branch 4 times, most recently from 7c78224 to 1a1be61 Compare March 22, 2023 10:21
Copy link
Contributor

@martyfuhry martyfuhry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I haven't had the chance to run it here yet, but I will soon. Thanks!

mobile/lib/modules/album/providers/album.provider.dart Outdated Show resolved Hide resolved
mobile/lib/modules/backup/services/backup.service.dart Outdated Show resolved Hide resolved
mobile/lib/shared/models/store.dart Outdated Show resolved Hide resolved
mobile/lib/shared/models/store.dart Show resolved Hide resolved
mobile/lib/shared/models/store.dart Show resolved Hide resolved
@fyfrey fyfrey force-pushed the dev/migrate-all-hive-boxes-to-isar branch from 1a1be61 to c84d5bf Compare March 22, 2023 16:45
@alextran1502 alextran1502 merged commit eccde8f into main Mar 23, 2023
@alextran1502 alextran1502 deleted the dev/migrate-all-hive-boxes-to-isar branch March 23, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants