Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): scrubber label and animation #13815

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Conversation

alextran1502
Copy link
Contributor

@alextran1502 alextran1502 commented Oct 29, 2024

  • Show the date label on the tracker on scroll
  • Add some small animation
capture-1.mov

@alextran1502 alextran1502 enabled auto-merge (squash) October 30, 2024 14:37
@alextran1502 alextran1502 merged commit 244c8cb into main Oct 30, 2024
36 checks passed
@alextran1502 alextran1502 deleted the scrubber-enhancement branch October 30, 2024 14:38
TimVanOnckelen pushed a commit to TimVanOnckelen/immich that referenced this pull request Nov 5, 2024
* feat(web): scrubber label and animation

* tune x fly in distance

* refactor

* lint and minor fix

* fly height
@hqm42
Copy link

hqm42 commented Nov 7, 2024

@alextran1502
This PR introduces an inconsistency in scrubber behaviour with localized date formats, as it uses the fixed en format 'MMM yyyy'.

When I hover over December 2023 with german locale I get "Dez. 2023". When I scroll to this position I get "Dec 2023".

@tkp-dev
Copy link

tkp-dev commented Nov 7, 2024

For large collections with lot of assets per day it would be nice to have DAY label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants