fix(mobile): do not removed not backup asset when selecting the correspond options #13256
Conversation
|
@mertalev Please add someone to review |
|
@shenlong-tanwen updated the implementation inside the |
This reverts commit 04f2ed5.
|
@shenlong-tanwen Any update on review ? |
There was a problem hiding this comment.
You could do one of the following:
i) You could use your previous implementation of having the filtering logic in the widget and remove all the filtering logic in the provider as it is redundant and has errors
ii) Fix the logical issue in the provider and remove your filtering logic and toast handling in the widget as the assets are already filtered in the provider
Also fix any issues from the dart analyzer as well
Apologies for not being more clearer with the previous comment. Thanks for working on this.
|
Thanks @shenlong-tanwen , I have updated the logic as per requirement. And, also removed UI logic from the provider code, as you mentioned and have implemented it from code perpective |
|
@yashrajjain726 The changes are good. Can you respond to the only remaining comment on why the refresh is needed? |
|
@shenlong-tanwen I have replied to it long time ago, please check. |
|
Hi @shenlong-tanwen , Can you please check again, I have updated as required. |
|
@alextran1502 Any update on the review ? |
alextran1502
changed the title
alextran1502
changed the title
…spond options (immich-app#13256) * fixed the local ids selecting issue * code: updated impl inside deleteLocalOnlyAssets * fix: used png instead of jpg to maintain picture quality * Revert "fix: used png instead of jpg to maintain picture quality" This reverts commit 04f2ed5. * fix: update logic from code-review perspective * refractor (mobile) : Dart fix applied * fix (mobile) : Updated multi grid as per requirement --------- Co-authored-by: Alex <[email protected]>
Fixed #11428