Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): single row of items #11729

Merged
merged 4 commits into from
Aug 13, 2024
Merged

fix(web): single row of items #11729

merged 4 commits into from
Aug 13, 2024

Conversation

michelheusschen
Copy link
Contributor

Single rows of items (such as on the explore page) have several issues:

  • Requires manual size calculation
  • Doesn't fill the entire row
  • Shows too few or too many items when zooming

Fixed by using grid instead of flexbox and using an action that automatically calculates the amount of items that fit. The width of the first item will be used and it assumes all items have equal width.

explore-page-items

@jrasm91 jrasm91 merged commit 5acdc95 into main Aug 13, 2024
22 checks passed
@jrasm91 jrasm91 deleted the fix/web-single-row-of-items branch August 13, 2024 12:20
Yuvi-raj-P pushed a commit to Yuvi-raj-P/immich that referenced this pull request Aug 19, 2024
* fix(web): single row of items

* remove filterBoxWidth

* slight size adjustment

* rewrite action as component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants