Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): handle numeric 'Image Description' and 'Description' values #11636

Conversation

jo-gross
Copy link
Contributor

@jo-gross jo-gross commented Aug 7, 2024

Fixed #11635 by ensuring that .trim() is always executed on type string

@jo-gross jo-gross changed the title Made 'Image Description' and 'Description' type safe during exif parsing fix(server): Made 'Image Description' and 'Description' type safe during exif parsing Aug 7, 2024
@michelheusschen
Copy link
Contributor

Ah I just fixed the same thing. I have pushed some additional changes

@jo-gross
Copy link
Contributor Author

jo-gross commented Aug 7, 2024

Ah I just fixed the same thing. I have pushed some additional changes

Oh yeah, looks great! Thank you!

@jrasm91 jrasm91 changed the title fix(server): Made 'Image Description' and 'Description' type safe during exif parsing fix(server): handle numeric 'Image Description' and 'Description' values Aug 7, 2024
@jrasm91 jrasm91 enabled auto-merge (squash) August 7, 2024 15:23
@jrasm91 jrasm91 merged commit 28ba22e into immich-app:main Aug 7, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on external library scan when adding photos with only numeric descriptions
4 participants