Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(server): remove get person asset limit #11597

Merged
merged 16 commits into from
Aug 6, 2024
Merged

chore(server): remove get person asset limit #11597

merged 16 commits into from
Aug 6, 2024

Conversation

alextran1502
Copy link
Contributor

@alextran1502 alextran1502 commented Aug 5, 2024 •
edited
Loading

This PR removes the limitation of getting the assets for each person by using the searchMetadata endpoint

jrasm91
jrasm91 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a good reason to change the page max from 1,000 to 5,000, but besides that this looks fine. I also don't care if we remove the endpoint immediately.

@alextran1502
Copy link
Contributor Author

@jrasm91 It affects the loading times if you are getting smaller batches vs bigger patches on the mobile client

@danieldietzler danieldietzler changed the title chore(server): remover get person asset limit chore(server): remove get person asset limit Aug 6, 2024
@alextran1502 alextran1502 enabled auto-merge (squash) August 6, 2024 16:20
@alextran1502 alextran1502 merged commit f040c9f into main Aug 6, 2024
22 checks passed
@alextran1502 alextran1502 deleted the chore/remove-getPersonAsset-limit branch August 6, 2024 16:22
@alextran1502 alextran1502 mentioned this pull request Aug 6, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

@danieldietzler danieldietzler Awaiting requested review from danieldietzler danieldietzler is a code owner

@fyfrey fyfrey Awaiting requested review from fyfrey

Assignees
No one assigned
Labels
changelog:bugfix 📱mobile 🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alextran1502 @jrasm91