Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): exif description whitespace handling #11249

Merged
merged 2 commits into from
Jul 21, 2024
Merged

fix(server): exif description whitespace handling #11249

merged 2 commits into from
Jul 21, 2024

Conversation

michelheusschen
Copy link
Contributor

Fixes #11238 which consists of two issues:

  1. Not possible to clear description of an asset with the Description exif tag
  2. Whitespace in exif description tags is included in the asset description

jrasm91
jrasm91 approved these changes Jul 20, 2024
View reviewed changes
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just or it with '' and then trim it without the ?.

danieldietzler
danieldietzler approved these changes Jul 20, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, since there are already two ORs just adding || '' at the end there makes sense to me as well

@jrasm91 jrasm91 merged commit 8b773a2 into main Jul 21, 2024
22 checks passed
@jrasm91 jrasm91 deleted the fix/server-exif-description-whitespace-handling branch July 21, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler approved these changes

@jrasm91 jrasm91 jrasm91 approved these changes

Assignees
No one assigned
Labels
🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't set image description to blank
3 participants
@michelheusschen @jrasm91 @danieldietzler