feat(mobile): Adding setting in mobile app to TLS client certificate #10860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ficate and private key
|
@alextran1502 Could you please approve another workflow test? Thanks! |
|
Sorry to fail the test again. I just push the commit to fix the test failure. |
|
It seems all tests passed. What is the next step to get approval? |
|
I will run some errands manually testing |
alextran1502
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add an advanced setting in Immich mobile app to import TLS client certificate and private key.
Some users deploy Immich server behind a reverse web proxy server like nginx. Through setting up reverse proxy server, immich client could be asked a TLS/SSL client certificate for authentication. This can add an additional secure layer to protect Immich server behind a reverse proxy.
immich_demo.mp4