Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eye viewport overlap #133

Closed
AdaRoseCannon opened this issue Jul 1, 2016 · 3 comments
Closed

Eye viewport overlap #133

AdaRoseCannon opened this issue Jul 1, 2016 · 3 comments

Comments

@AdaRoseCannon
Copy link
Member

Thanks for the awesome polyfill!!

Platform Samsung Galaxy S6, Chrome 50 and Samsung Browser

screenshot_20160701-131420

Works correctly on v0.9.15 breaks on v1.0.0. (Samsung browser)
Reproducible in Chrome 50 as well. (Thanks for getting it working in Chrome in v1.0.0 :D)

@borismus
Copy link
Contributor

borismus commented Jul 5, 2016

Could you link to a reduced test case?

On Fri, Jul 1, 2016 at 5:16 AM Ada Rose Edwards [email protected]
wrote:

Thanks for the awesome polyfill!!

Platform Samsung Galaxy S6, Chrome 50 and Samsung Browser

[image: screenshot_20160701-131420]
https://cloud.githubusercontent.com/assets/4225330/16521253/94250cbc-3f8d-11e6-984f-b9ea01acb880.png

Works correctly on v0.9.15 breaks on v1.0.0. (Samsung browser)
Reproducible in Chrome 50 as well. (Thanks for getting it working in
Chrome in v1.0.0 :D)


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#133, or mute the
thread
https://github.com/notifications/unsubscribe/AAQ8gI7zKa-MtrUPWVS1-bGzilyt4GsCks5qRQUvgaJpZM4JDF2a
.

@jsantell
Copy link
Contributor

Are you finding any matches in the local dpdb? There are a few Samsung Galaxy models in there. If not, adding new device parameters I'm hoping will work, but we may need to do more than just matching UA strings (more info in this issue for the Galaxy S6)

@jsantell
Copy link
Contributor

Moving Samsung resolution handling to fix incorrect distortions to immersive-web/cardboard-vr-display#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants