Add step by step instructions on finding your device's info #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 23, 2017
cvan
suggested changes
May 23, 2017
README.md
Outdated
|
|
||
| ```json | ||
| { | ||
| "type":"android", |
There was a problem hiding this comment.
can we run this through JSON.stringify(JSON.parse(…)) to properly format spaces?
README.md
Outdated
|
|
||
| * `type`: Either `"android"` or `"ios"`. | ||
| * `rules`: An array of various rules that must be satisfied in order to use the configuration. Each rule is an object with one property and can be one of the following: | ||
| * `ua`: The user agent string to match. Go to [useragentstring.com] and find something unique that looks like the device's name. Use this if type is `"android"`. |
There was a problem hiding this comment.
can you indent this by 4 spaces so it's properly indented on GitHub?
There was a problem hiding this comment.
user agent string -> User-Agent string
README.md
Outdated
| * `rules`: An array of various rules that must be satisfied in order to use the configuration. Each rule is an object with one property and can be one of the following: | ||
| * `ua`: The user agent string to match. Go to [useragentstring.com] and find something unique that looks like the device's name. Use this if type is `"android"`. | ||
| * `res`: An array of resolution values as width and height. Use this if type is `"ios"`. | ||
| * `mdmh`: The make and model of the device. Currently unused in [webvr-polyfill], and used for native devices(?) -- see other entries. |
There was a problem hiding this comment.
(?) - can we confirm this with someone?
README.md
Outdated
| * `ua`: The user agent string to match. Go to [useragentstring.com] and find something unique that looks like the device's name. Use this if type is `"android"`. | ||
| * `res`: An array of resolution values as width and height. Use this if type is `"ios"`. | ||
| * `mdmh`: The make and model of the device. Currently unused in [webvr-polyfill], and used for native devices(?) -- see other entries. | ||
| * `dpi`: An array of the DPI values of the screen as `[x, y]` values. Get this information via [Device Info App] and look for `Actual DPI X` and `Actual DPI Y` values. |
There was a problem hiding this comment.
via [Device -> via the [Device
README.md
Outdated
| * `ac`: Currently unused in [webvr-polyfill]? | ||
| * `bw`: The bezel width in millimeters. 3 and 4 are common bezel widths, but you can calculate the exact width using this formula, where `deviceWidth` is in millimeters, `screen` is the screen's diagonal length in millimeters, and `ratio` is the screen resolution's `width / height`: | ||
|
|
||
| ``` |
|
@cvan Made all the changes -- asking around about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will clear up a lot of issues in webvr-polyfill of people wanting to add their own devices to dpdb, as well as reference for those wanting to add locally.
A sanity check on the bezel width math would be appreciated as well!