Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: do not assume system timezone is UTC #713

Closed

Conversation

justingrant
Copy link
Contributor

Fixes #712 by initializing all Date instances with UTC values, not local-timezone values.

Fixes immerjs#712 by initializing all Date instances with UTC values,
not local-timezone values.
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ebc0ebb:

Sandbox Source
Immer sandbox Configuration

@Gelio
Copy link
Contributor

Gelio commented Nov 29, 2020

Looks like duplicate effort with #705

@justingrant
Copy link
Contributor Author

@Gelio - Yep you're right. My apologies for not checking for duplicates. Closing this PR in favor of #705.

@Gelio
Copy link
Contributor

Gelio commented Nov 29, 2020

Not a problem 🙂 Thanks for showing a different solution to the same problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail when run in non-UTC time zone
2 participants