Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix Buffer deprecation warning in test #706

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

Gelio
Copy link
Contributor

@Gelio Gelio commented Nov 21, 2020

There was a deprecation warning because new Buffer([]) was used in one of the tests.

(node:25795) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
 PASS  __tests__/manual.js

image

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 52585cd:

Sandbox Source
Immer sandbox Configuration

@mweststrate
Copy link
Collaborator

Thanks!

@mweststrate mweststrate merged commit d75de70 into immerjs:master Jan 20, 2021
@Gelio Gelio deleted the remove-buffer-deprecation-warning branch January 20, 2021 10:13
@mweststrate
Copy link
Collaborator

🎉 This PR is included in version 8.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants