Use UTC date string in tests to be timezone independent #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously tests could break when run in a different timezone.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2aca904:
|
|
Thanks for fixing this! |
|
🎉 This PR is included in version 8.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 7, 2021
This was referenced Mar 14, 2021
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that one of the tests failed when run locally (I am in the CET timezone ATM), because the stringified date did not match the snapshot (was 1 hour off):
This probably stems from the fact that the
Dateconstructor parses the values as though they were in the local timezone (CET +1 for me). Going back to UTC (which is whattoJSONproduces) subtracts that 1 hour, which makes it show 7:08:08 instead of 8:08:08.I reckon using a UTC string could solve the problem. Another alternative would be using a constructor with a UNIX timestamp, but I reckon the current solution is more readable.
Fixes #712