Couldn't find previous issue with labels

[spier]

Hi @imjohnbo,

First of all, thank you for this great GitHub Action.
I found it today and got it up and running based on the examples very smoothly and quickly.

When I was trying out a bit more complex configuration I ran into one issue.

I wanted to try these configuration options:

pinned: true
linked-comments: true

In my setup the GHA is triggered when a given issue is closed.
e.g. whenever an issue with a certain title gets closed, it creates a new issue based on a template.

However with the config options above the GHA execution results in this error:

Finding previous issue with labels: ["good first issue"]...
Error: Error encountered: Error: Couldn't find previous issue with labels: ["good first issue"]..

Workflow where I tried this out (the options above are commented out right now to fix the GHA fun for the time being):
https://github.com/spier/gha-auto-issue-creation/blob/main/.github/workflows/auto-create-social-following-and-share.yml

Full error log here
https://github.com/spier/gha-auto-issue-creation/actions/runs/961911147

I traced the error down to this part of the source code:
https://github.com/imjohnbo/issue-bot/blob/main/lib/issue-bot.js#L193-L211

Is it maybe that the previous issue still needs to "open" at the time when issue-bot tries to unpin it and comment on it?

[imjohnbo]

Thanks for the detailed report and sorry to have missed this, @spier! I think I have a fix for you here. Would you like to test on the fix/issue-51 branch (uses: imjohnbo/issue-bot@fix/issue-51) before I cut a new release tomorrow? Otherwise I'll dig in further and provide a fix in a different release.

[spier]

Thanks @imjohnbo

I tried it out:

• it doesn't throw the error anymore that I saw previously, so that's great :)
• however I don't see any effects of the pinned and linked-comments config option either

Is it possible that those two options only work when I also set close-previous: true at the same time?

My current workflow config:
https://github.com/spier/gha-auto-issue-creation/blob/main/.github/workflows/auto-create-social-following-and-share.yml

[imjohnbo]

Thanks for testing, @spier. I should have just fixed that here on the same branch; the previous assumption was that issues in the series would be open, just an oversight.

Let me know how it goes?

[spier]

To make it more clear what the answer to this discussion is:

Change your workflow to use imjohnbo/issue-bot@v3 and the issue described above will be solved.

[spier]

Yes, this works flawlessly for me now.

Cases tested:

• old issue [ with matching title | pinned ] => creates new pinned issue. creates both way links between old/new issue.
• old issue [ with matching title | not pinned ] => creates new pinned issue. creates both way links between old/new issue.
• old issue [ with some other title title | not pinned ] => nothing happens (as it should)

Thanks a lot! 🚀

Would be awesome if you could let me know when you cut a new release, so that I can upgrade to the correct new version.

[imjohnbo]

Great, thanks for confirming! If you can wait until Monday, I'll give this bug report a chance to test before cutting a new release. 🙇

[spier]

Yeah, I can absolutely wait til Monday. No rush at all.

[spier]

Oh, GH Discussions have threads? Neat! :)

[imjohnbo]

Yeah we're finding out / remembering together 🙌

[spier]

Hi @imjohnbo.

I was just trying out that release v3.3.3 and it doesn't seem to behave the same as when I was testing with the fix/issue-51 branch directly.

So I assume the fix from branch fix/issue-51 did not make it into the latest release v3.3.3, did it?

No rush with any of this. Just wanted to know if I am seeing the right thing.

[imjohnbo]

Uh oh... may be a regression. I really need better testing!

What are you seeing now?

[imjohnbo]

The change I added this week was that isPinned should now work irrespective of closePrevious.

[spier]

What I am seeing on my testing repo is that issues that were previously pinned, still stay pinned even after the new issues is created. So the pinning works but not the un-pinning.

See testing repo: https://github.com/spier/gha-auto-issue-creation/issues

I am assuming that this is because the Action doesn't find the previous issue.
Snippet from the logs:

Finding previous issue with labels: ["good first issue"]...
Couldn't find previous issue with labels: ["good first issue"].

This seems similar to the original issues reported at the very top of this discussion, however this time not raising an error.

I wonder if I am using the Action correctly?

I tried to specify the version as imjohnbo/issue-bot@v3 as well as imjohnbo/[email protected].
Both with the same result.

And as for better testing:
Yeah, I would also be interested in learning how to do proper testing for a GHA, given that it relies on GitHub events to trigger the Action.

I guess both the input event as well as the output API calls towards GitHub would have to be stubbed/simulated? i.e. one would just test "if the issue-bot receives a GitHub event like AAA, it will generate a GitHub API call like BBB"

[imjohnbo]

Uh oh... may be a regression.

It was unmerged code! 😄 🤦 Would you mind pointing to v3, v3.3, or v3.3.4? 🙏 Thanks for your patience, @spier. ✨

[spier]

Happens to the best :)

I tried v3. It's working now 🚀

Thank you for the quick follow-up.