Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItemCollection - restrict to basic types #347

Closed
rsoika opened this issue Feb 18, 2018 · 0 comments
Closed

ItemCollection - restrict to basic types #347

rsoika opened this issue Feb 18, 2018 · 0 comments

Comments

@rsoika
Copy link
Member

rsoika commented Feb 18, 2018

A ItemCollection should not store values which are not in the group ob basic types:

// test raw array types first
	if (o instanceof byte[] || o instanceof boolean[] || o instanceof short[] || o instanceof char[]
			|| o instanceof int[] || o instanceof long[] || o instanceof float[] || o instanceof double[]
		    || o instanceof XMLItem[]		
			) {
		continue;
	}
		// test package name
	Class c = o.getClass();
	String name = c.getName();
	if (!name.startsWith("java.lang.") && !name.startsWith("java.math.") && !"java.util.Date".equals(name)
			&& !"org.imixs.workflow.xml.XMLItem".equals(name)) {
		return false;
	}

This restriction is currently implemented by the XMLItem class.
But we should also avoid this basically on the ItemCollection level itself.

@rsoika rsoika added this to the 4.2.6 milestone Feb 18, 2018
rsoika added a commit that referenced this issue Feb 18, 2018
issue #347
@rsoika rsoika added the testing label Feb 18, 2018
rsoika added a commit that referenced this issue Feb 19, 2018
rsoika added a commit that referenced this issue Feb 19, 2018
@rsoika rsoika closed this as completed Mar 2, 2018
bvfalcon pushed a commit to bvfalcon/imixs-workflow that referenced this issue Jul 6, 2021
bvfalcon pushed a commit to bvfalcon/imixs-workflow that referenced this issue Jul 6, 2021
bvfalcon pushed a commit to bvfalcon/imixs-workflow that referenced this issue Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant