Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize SyncService #64

Closed
rsoika opened this issue Jun 25, 2019 · 0 comments
Closed

Optimize SyncService #64

rsoika opened this issue Jun 25, 2019 · 0 comments
Labels
enhancement
Milestone
2.0.0

Comments

@rsoika
Copy link
Member

rsoika commented Jun 25, 2019

The SyncService should not load 100 snapshots per run but only one by one. This is to avoid heapspace memory problems on the WorkflowInstance.
It also does not make sense to wait after 100 snapshots for a minute. We can adapt the same mechanism as in the ExportService and sync all data at once and only log a message after 100 or 500 syncs.
@rsoika rsoika added this to the 2.0.0 milestone Jun 25, 2019
rsoika added a commit that referenced this issue Jun 25, 2019
@rsoika
refactoring
dbb16be 
Issue #64
@rsoika rsoika closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@rsoika