Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export winit and glow crates #676

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Re-export winit and glow crates #676

merged 1 commit into from
Nov 22, 2022

Conversation

lovelymono
Copy link
Contributor

This makes it easier for users to use the correct version of these crates.

Signed-off-by: Lena Milizé [email protected]

Signed-off-by: Lena Milizé <[email protected]>
@MarijnS95
Copy link
Contributor

MarijnS95 commented Nov 8, 2022

Seems like an okay change, but I rather prefer that users themselves determine their winit/glow version (based on more needs than just the imgui crate), and select an appropriate imgui version to match. This wouldn't be such an issue if imgui just released more often and more consistently, it's currently holding up the winit bump around the ecosystem for everyone using imgui-winit-support (see open issues and PRs about releases and the process around it).

@dbr
Copy link
Contributor

dbr commented Nov 22, 2022

Agreed - I think this is worth merging as it'll make the simple case easier ("just want imgui to work"), and doesn't preclude more careful selection of versions where needed

Also certainly agreed about releasing more often 😅 Working on that now

@dbr dbr merged commit 8329cd7 into imgui-rs:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants