Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove stale .d.ts file from dist #293

Merged
merged 1 commit into from
Jun 22, 2021
Merged

build: remove stale .d.ts file from dist #293

merged 1 commit into from
Jun 22, 2021

Conversation

sherwinski
Copy link
Contributor

Noticed there was an old version of the project's TS definitions file floating around in the dist directory.

@sherwinski sherwinski requested a review from a team as a code owner June 22, 2021 21:12
@commit-lint
Copy link

commit-lint bot commented Jun 22, 2021

Build System

  • remove stale .d.ts file from dist (a3008b1)

Contributors

sherwinski

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@luqven
Copy link
Contributor

luqven commented Jun 22, 2021

Ah that's my bad. I saw this and figured for some reason the OG was missing. Didn't realize this was an out dated version.

luqven
luqven approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@luqven luqven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sherwinski sherwinski merged commit 38fdd2e into main Jun 22, 2021
@sherwinski sherwinski deleted the remove-stale-ts-definitions branch June 22, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luqven luqven luqven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sherwinski @luqven