Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve error messages for target width validator #267

Merged
merged 1 commit into from
Mar 25, 2021
Merged

fix: improve error messages for target width validator #267

merged 1 commit into from
Mar 25, 2021

Conversation

frederickfogerty
Copy link
Contributor

The error message isn't quite correct, so I improved it a little.

@frederickfogerty frederickfogerty requested a review from a team as a code owner March 24, 2021 09:19
@commit-lint
Copy link

commit-lint bot commented Mar 24, 2021 •
edited
Loading

Bug Fixes

  • improve error messages for target width validator (0297576)

Contributors

frederickfogerty

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

ericdeansanchez
ericdeansanchez approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@ericdeansanchez ericdeansanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!!!

@frederickfogerty frederickfogerty force-pushed the f/improve-validator-error-messages branch from 6d1aca2 to 0297576 Compare March 25, 2021 07:58
@frederickfogerty
Copy link
Contributor Author

I've rebased this onto main after the .js changes

@frederickfogerty frederickfogerty enabled auto-merge (rebase) March 25, 2021 07:59
@frederickfogerty frederickfogerty merged commit d42986c into main Mar 25, 2021
@frederickfogerty frederickfogerty deleted the f/improve-validator-error-messages branch March 25, 2021 08:01
@ericdeansanchez ericdeansanchez mentioned this pull request Mar 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericdeansanchez ericdeansanchez ericdeansanchez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederickfogerty @ericdeansanchez