Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Z3 package #4

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add Z3 package #4

wants to merge 2 commits into from

Conversation

wintersteiger
Copy link

This adds a package that install the latest Z3 master.

@Bronsa
Copy link
Member

Bronsa commented Nov 28, 2023

let's not do this as master is a moving target. can we just use the specific commit sha instead?

@wintersteiger
Copy link
Author

Sure, that's easy to add. I was wondering whether it's possible to do both. How does opam decide which version to install by default?

@Bronsa
Copy link
Member

Bronsa commented Nov 28, 2023

I propose just using /archive/sha.zip and as version we can use 4.12.3-$(number of commits) -- e.g for 3422f44cea4e73572d1e22d1c483a960ec788771 we'd have 4.12.3-18247 to keep it monotonically increasing

@Bronsa
Copy link
Member

Bronsa commented Nov 28, 2023

Sure, that's easy to add. I was wondering whether it's possible to do both. How does opam decide which version to install by default?

I'm not sure it's possible to have master since it would break the checksum as soon as the target moves.

opam uses latest version that satisfies constraints, sorted lexicographically

@wintersteiger
Copy link
Author

Yeah, master would have to be without a hash, but I don't expect opam to allow that.

How did you arrive at 4.12.3-18247? There isn't a 4.12.3 release and I get 358 since 4.12.2.

@wintersteiger
Copy link
Author

Oh, I get it, total number of commits, I was counting the ones since 4.12.2.

@Bronsa
Copy link
Member

Bronsa commented Nov 28, 2023

How did you arrive at 4.12.3-18247? There isn't a 4.12.3 release and I get 358 since 4.12.2.

last released is 4.12.2 so i've just incremented to 4.12.3 to force the opam solver to pick this

Oh, I get it, total number of commits, I was counting the ones since 4.12.2.

yeah it's arbitrary, either would do :)

@wintersteiger
Copy link
Author

I changed it to 4.12.2+358 and to my surprise nothing complained about the +!

@wintersteiger wintersteiger changed the title Add Z3 master Add Z3 package Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants