Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilding jpegtran if make available and on Unix #2

Closed
wants to merge 5 commits into from
Closed

Rebuilding jpegtran if make available and on Unix #2

wants to merge 5 commits into from

Conversation

anacronw
Copy link

I could not get 1.2.1 to work on my system with the config flags you specified on the README. Didn't spend the time to figure out what's wrong with the environment or what files I'm missing. I tried 1.2.9 (in beta as of 2 days ago) and it worked just fine so I have committed that instead.

@anacronw
Copy link
Author

The build takes quite long actually. I realize its trying to compile 4 binaries I think - a glance at the make file wasn't obvious whether I could do just jpegtran.

Also, do you know whether there is a config option here to specify the output path like in optipng?

@sindresorhus
Copy link
Contributor

The build takes quite long actually. I realize its trying to compile 4 binaries I think - a glance at the make file wasn't obvious whether I could do just jpegtran.

Good question. No idea... But we should only compile jpegtran.

Also, do you know whether there is a config option here to specify the output path like in optipng?

You could borrow from Homebrew: https://github.com/mxcl/homebrew/blob/master/Library/Formula/jpeg-turbo.rb

@anacronw
Copy link
Author

I found the parameters in the Makefile to build only jpegtran, please give it a try :)

@sindresorhus
Copy link
Contributor

Travis fails. Can you look into it?

> node build.js

undefined

@sindresorhus sindresorhus reopened this Feb 27, 2013
@anacronw
Copy link
Author

I think that occurs when make is not available. Since it can't be compiled, it can also fail the test. I'll check closer tonight.

I'm not quite sure why the existing tests also fail though.

@anacronw
Copy link
Author

ok, it passes now - issue was simply that I forgot to build in support for 64 bit vs 32 bit linux

@sindresorhus
Copy link
Contributor

The last commit fails, "modified paths to diverge...", see the Travis status.

@sindresorhus
Copy link
Contributor

Also looks like there is a problem on Windows: gruntjs/grunt-contrib-imagemin#16 (comment) Could you take a look?

@anacronw
Copy link
Author

I had to keep bouncing back and forth from a VM, maybe it confused github, but the latest is actually the one that passed (travis build #8 - https://travis-ci.org/yeoman/node-jpegtran-bin/builds/5129391)

I'll take a look at the windows one, but I don't have access to a windows box :/

@sindresorhus
Copy link
Contributor

I'll take a look at the windows one, but I don't have access to a windows box :/

Yeah, me neither...

@sindresorhus
Copy link
Contributor

It runs fine on Travis now, but won't build on my Mac, it just returns with undefined:

❯ node build.js
undefined

@ghost
Copy link

ghost commented Mar 10, 2013

You have to install "Command Line Tools for XCode".
Go to Preferences in Xcode, choose Downloads and install Command Line Tools.

@sindresorhus
Copy link
Contributor

That was not the issue. I of course have Xcode CLI installed ;)

@ghost
Copy link

ghost commented Mar 10, 2013

Funny. After installing CLI Tools it work on all my three mac's.

@anacronw
Copy link
Author

@sindresorhus Just making sure - its building on osx for you now after the latest PR right?

@sindresorhus
Copy link
Contributor

@Badunk yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants