-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix clippy::into_iter_on_array error in decoder #116
Conversation
CI failure doesn't look like the fault of this change:
|
Looks like rayon isn't actually compatible with 1.28 anymore (due to some indirect dependency on the latest cfg-if). |
Maybe |
Nah, you don't commit Cargo.lock for libraries. Then CI would pass but it would still fail to build on 1.28 for everyone depending on this crate. One solution is to depend on cfg-if =0.1.9, but that's probably just causing even more problems, so 1.28 should probably just be dropped. |
@fintelia Do you think this fix can be released with a minor version bump (i.e. 0.1.17)? That would be really great, as |
@LukasKalbertodt 0.1.17 has now been published. |
fix clippy::into_iter_on_array error in decoder
Rust is trying to add
IntoIterator
for arrays, which would break this. So might as well do it the way that's forward-compatible and also shorter.