Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

86 add roi analysis tutorial #89

Merged
merged 31 commits into from
Feb 21, 2024
Merged

86 add roi analysis tutorial #89

merged 31 commits into from
Feb 21, 2024

Conversation

EscapedGibbon
Copy link
Contributor

close: #86

@EscapedGibbon EscapedGibbon linked an issue Jan 15, 2024 that may be closed by this pull request
add roi analysis tutorial #86
Closed
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 15, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 692c073
Status: ✅  Deploy successful!
Preview URL: https://c7d22411.image-js-docs.pages.dev
Branch Preview URL: https://86-add-roi-analysis-tutorial.image-js-docs.pages.dev

View logs

@EscapedGibbon EscapedGibbon marked this pull request as ready for review February 7, 2024 13:32
@EscapedGibbon EscapedGibbon marked this pull request as draft February 9, 2024 09:10
@EscapedGibbon EscapedGibbon marked this pull request as ready for review February 9, 2024 12:55
@stropitek
Copy link
Contributor

Should be the first thing to say in the tutorial

Also no need to make it a warning, it can be just a "note"

CleanShot 2024-02-13 at 16 58 53

@stropitek
Copy link
Contributor

I don't think anyone wants to read a long list of numbers in a table with many digits

You can show the distribution in a graph or add the value in the image next to the region of interest (but cut the many digits)

@stropitek
Copy link
Contributor

CleanShot 2024-02-16 at 10 13 43

It would make more sense to draw a horizontal line here to show where the cutoff is. You can put "nuts" and "washers" in a legend with the right color association.

Also the cutoff you chose is overfitting the data and probably does not generalize well on new images of nuts and washers. No need to start expanding on classifiers, but you should mention it.

@stropitek
Copy link
Contributor

I really think the table of numbers can go away.

@stropitek
Copy link
Contributor

@targos can you review the page on metadata?

https://86-add-roi-analysis-tutorial.image-js-docs.pages.dev/docs/Tutorials/Extracting%20metadata

@targos
Copy link
Member

targos commented Feb 21, 2024

The contents look fine and we can merge it, but I would not have agreed to doing a tutorial on metadata at this point. This is one of the less stable and thought of APIs in ImageJS.

About "Getting extra data", maybe mention somewhere that it is XML? It's weird to use a custom-made parser to handle it.

@EscapedGibbon
Copy link
Contributor Author

The contents look fine and we can merge it, but I would not have agreed to doing a tutorial on metadata at this point. This is one of the less stable and thought of APIs in ImageJS.

About "Getting extra data", maybe mention somewhere that it is XML? It's weird to use a custom-made parser to handle it.

Added the mention.

@stropitek
Copy link
Contributor

When referring to classifiers, maybe use a more specific reference. "Machine learning" is a very broad term.

https://en.wikipedia.org/wiki/Statistical_classification

stropitek
stropitek approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just update the link

@EscapedGibbon
Copy link
Contributor Author

LGTM, just update the link

Done

@stropitek stropitek merged commit 39636dc into main Feb 21, 2024
7 checks passed
@stropitek stropitek deleted the 86-add-roi-analysis-tutorial branch February 21, 2024 15:56
EscapedGibbon added a commit that referenced this pull request Feb 26, 2024
@EscapedGibbon
feat: add roi analysis tutorial and explanations about image metadata (…
cd8a79d 
…#89)

* docs wip write roi analysis page

* docs wip add some code for analysis

* docs wip add images and

* docs wip add images of metadata

* docs wip add code examples

* docs: add quotes to some tags mentions

* add: extra data images and roi properties table

* docs: replace an image with comparison

* docs: fix spelling check

* docs: improve text and fix minor errors

* docs: create metadata tutorial and add more code to roi tutorial

* docs wip rework roi analysis page

* docs: move distribution graph

* docs: fix case sensitivity error

* docs: fix the unit in pixel size

* docs wip change roundness part of the tutorial

* docs wip add screws image analysis

* docs: add explanations to irregular behavior of some ROIs and add images

* docs wip explain how to sort nuts from washers

* docs: add final result and remove unused images

* docs: add minor changes and fix minor errors

* docs: add more details to metadata intro

* docs: make minor changes

* docs: redo size distribution example and fix screws example

* docs: improve phrasing in metadata tutorial

* docs: minor fixes in code examples

* docs: resolve conversations

* docs: restructure mbr graph

* docs: add XML mention to extra data

* docs: update machine learning classifier link
EscapedGibbon added a commit that referenced this pull request Feb 28, 2024
@EscapedGibbon
feat: add roi analysis tutorial and explanations about image metadata (…
6ee1b76 
…#89)

* docs wip write roi analysis page

* docs wip add some code for analysis

* docs wip add images and

* docs wip add images of metadata

* docs wip add code examples

* docs: add quotes to some tags mentions

* add: extra data images and roi properties table

* docs: replace an image with comparison

* docs: fix spelling check

* docs: improve text and fix minor errors

* docs: create metadata tutorial and add more code to roi tutorial

* docs wip rework roi analysis page

* docs: move distribution graph

* docs: fix case sensitivity error

* docs: fix the unit in pixel size

* docs wip change roundness part of the tutorial

* docs wip add screws image analysis

* docs: add explanations to irregular behavior of some ROIs and add images

* docs wip explain how to sort nuts from washers

* docs: add final result and remove unused images

* docs: add minor changes and fix minor errors

* docs: add more details to metadata intro

* docs: make minor changes

* docs: redo size distribution example and fix screws example

* docs: improve phrasing in metadata tutorial

* docs: minor fixes in code examples

* docs: resolve conversations

* docs: restructure mbr graph

* docs: add XML mention to extra data

* docs: update machine learning classifier link
stropitek pushed a commit that referenced this pull request Mar 1, 2024
@EscapedGibbon
docs: add missing pages for certain functions (#102)
5bca291 
* docs: add holes info page

* docs: move one line explanation to the right spot

* docs: add clearBorder page

* docs: make changes to operations main page

* docs: add paintMask page

* docs: add ellipse page

* docs: minor changes in clearBorder

* docs: minor fixes

* docs: fix links to options' docs

* docs: fix links on clearBorder page

* docs: add image example to paintMask

* docs: explain image coordinates in getting started (#96)

* docs: implement feedback to getting started and basic section (#99)

* docs: fix misuse of word "kernel"

close: #101

* feat: add roi analysis tutorial and explanations about image metadata (#89)

* docs wip write roi analysis page

* docs wip add some code for analysis

* docs wip add images and

* docs wip add images of metadata

* docs wip add code examples

* docs: add quotes to some tags mentions

* add: extra data images and roi properties table

* docs: replace an image with comparison

* docs: fix spelling check

* docs: improve text and fix minor errors

* docs: create metadata tutorial and add more code to roi tutorial

* docs wip rework roi analysis page

* docs: move distribution graph

* docs: fix case sensitivity error

* docs: fix the unit in pixel size

* docs wip change roundness part of the tutorial

* docs wip add screws image analysis

* docs: add explanations to irregular behavior of some ROIs and add images

* docs wip explain how to sort nuts from washers

* docs: add final result and remove unused images

* docs: add minor changes and fix minor errors

* docs: add more details to metadata intro

* docs: make minor changes

* docs: redo size distribution example and fix screws example

* docs: improve phrasing in metadata tutorial

* docs: minor fixes in code examples

* docs: resolve conversations

* docs: restructure mbr graph

* docs: add XML mention to extra data

* docs: update machine learning classifier link

* docs: minor fixes in links (#104)

* docs: fix minor issues in basics section

* docs: fix minor issues in filters section

* docs: fix minor issues in comparison section

* docs: fix minor issues in geometry section

* docs: minor fixes in morphology section

* docs: minor fixes in operations section

* docs: minor fixes in roi analysis section

* docs: minor fixes in tips section

* docs: minor fixes in tutorials section

close: #81

* docs: remove invalid link

* docs: fix prettier error

* docs: fix prettier error

* docs: remove unnecessary meta-code comment

* docs: remove misleading quotes in the default value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stropitek stropitek stropitek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add roi analysis tutorial
3 participants
@EscapedGibbon @stropitek @targos