test for bug jj-vcs#2895

ilyagr · May 3, 2024 · aa08775 · aa08775
2 parents de60e87 + 07f5835
commit aa08775
Show file tree

Hide file tree

Showing 13 changed files with 608 additions and 252 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### New features
 
+* Conflict markers now include an explanation of what each part of the conflict
+  represents.
+
+
 ### Fixed bugs
 
 ## [0.17.0] - 2024-05-01

diff --git a/cli/tests/test_cat_command.rs b/cli/tests/test_cat_command.rs
@@ -89,11 +89,11 @@ fn test_cat() {
     test_env.jj_cmd_ok(&repo_path, &["rebase", "-r", "@", "-d", "@--"]);
     let stdout = test_env.jj_cmd_success(&repo_path, &["cat", "file1"]);
     insta::assert_snapshot!(stdout, @r###"
-    <<<<<<<
-    %%%%%%%
+    <<<<<<< Conflict 1 of 1
+    %%%%%%% Changes from base to side #1
     -b
     +a
-    +++++++
+    +++++++ Contents of side #2
     c
     >>>>>>>
     "###);

diff --git a/cli/tests/test_chmod_command.rs b/cli/tests/test_chmod_command.rs
@@ -71,11 +71,11 @@ fn test_chmod_regular_conflict() {
     let stdout = test_env.jj_cmd_success(&repo_path, &["cat", "file"]);
     insta::assert_snapshot!(stdout, 
     @r###"
-    <<<<<<<
-    %%%%%%%
+    <<<<<<< Conflict 1 of 1
+    %%%%%%% Changes from base to side #1
     -base
     +x
-    +++++++
+    +++++++ Contents of side #2
     n
     >>>>>>>
     "###);
@@ -90,11 +90,11 @@ fn test_chmod_regular_conflict() {
     let stdout = test_env.jj_cmd_success(&repo_path, &["cat", "file"]);
     insta::assert_snapshot!(stdout, 
     @r###"
-    <<<<<<<
-    %%%%%%%
+    <<<<<<< Conflict 1 of 1
+    %%%%%%% Changes from base to side #1
     -base
     +x
-    +++++++
+    +++++++ Contents of side #2
     n
     >>>>>>>
     "###);
@@ -107,11 +107,11 @@ fn test_chmod_regular_conflict() {
     let stdout = test_env.jj_cmd_success(&repo_path, &["cat", "file"]);
     insta::assert_snapshot!(stdout, 
     @r###"
-    <<<<<<<
-    %%%%%%%
+    <<<<<<< Conflict 1 of 1
+    %%%%%%% Changes from base to side #1
     -base
     +x
-    +++++++
+    +++++++ Contents of side #2
     n
     >>>>>>>
     "###);
@@ -201,10 +201,10 @@ fn test_chmod_file_dir_deletion_conflicts() {
     let stdout = test_env.jj_cmd_success(&repo_path, &["cat", "-r=file_deletion", "file"]);
     insta::assert_snapshot!(stdout,
     @r###"
-    <<<<<<<
-    +++++++
+    <<<<<<< Conflict 1 of 1
+    +++++++ Contents of side #1
     a
-    %%%%%%%
+    %%%%%%% Changes from base to side #2
     -base
     >>>>>>>
     "###);
@@ -234,10 +234,10 @@ fn test_chmod_file_dir_deletion_conflicts() {
     let stdout = test_env.jj_cmd_success(&repo_path, &["cat", "-r=file_deletion", "file"]);
     insta::assert_snapshot!(stdout,
     @r###"
-    <<<<<<<
-    +++++++
+    <<<<<<< Conflict 1 of 1
+    +++++++ Contents of side #1
     a
-    %%%%%%%
+    %%%%%%% Changes from base to side #2
     -base
     >>>>>>>
     "###);

diff --git a/cli/tests/test_diffedit_command.rs b/cli/tests/test_diffedit_command.rs
@@ -395,11 +395,11 @@ fn test_diffedit_merge() {
     assert!(!repo_path.join("file1").exists());
     let stdout = test_env.jj_cmd_success(&repo_path, &["print", "file2"]);
     insta::assert_snapshot!(stdout, @r###"
-    <<<<<<<
-    %%%%%%%
+    <<<<<<< Conflict 1 of 1
+    %%%%%%% Changes from base to side #1
     -a
     +c
-    +++++++
+    +++++++ Contents of side #2
     b
     >>>>>>>
     "###);

diff --git a/cli/tests/test_interdiff_command.rs b/cli/tests/test_interdiff_command.rs
@@ -153,11 +153,11 @@ fn test_interdiff_conflicting() {
     --- a/file
     +++ b/file
     @@ -1,7 +1,1 @@
-    -<<<<<<<
-    -%%%%%%%
+    -<<<<<<< Conflict 1 of 1
+    -%%%%%%% Changes from base to side #1
     --foo
     -+abc
-    -+++++++
+    -+++++++ Contents of side #2
     -bar
     ->>>>>>>
     +def

diff --git a/cli/tests/test_obslog_command.rs b/cli/tests/test_obslog_command.rs
@@ -59,10 +59,10 @@ fn test_obslog_with_or_without_diff() {
     @  rlvkpnrz [email protected] 2001-02-03 08:05:10 66b42ad3
     │  my description
     │  Resolved conflict in file1:
-    │     1    1: <<<<<<<resolved
-    │     2     : %%%%%%%
+    │     1    1: <<<<<<< Conflict 1 of 1resolved
+    │     2     : %%%%%%% Changes from base to side #1
     │     3     : -foo
-    │     4     : +++++++
+    │     4     : +++++++ Contents of side #2
     │     5     : foo
     │     6     : bar
     │     7     : >>>>>>>
@@ -111,10 +111,10 @@ fn test_obslog_with_or_without_diff() {
     --- a/file1
     +++ b/file1
     @@ -1,7 +1,1 @@
-    -<<<<<<<
-    -%%%%%%%
+    -<<<<<<< Conflict 1 of 1
+    -%%%%%%% Changes from base to side #1
     --foo
-    -+++++++
+    -+++++++ Contents of side #2
     -foo
     -bar
     ->>>>>>>