Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use local variable type inference #995

Merged
merged 5 commits into from
Oct 21, 2019
Merged

Use local variable type inference #995

merged 5 commits into from
Oct 21, 2019

Conversation

zbeach
Copy link
Contributor

@zbeach zbeach commented Oct 12, 2019

Update the following patterns with local variable type inference:

  • typeobjectpattern
  • unit-of-work
  • value-object
  • visitor

This solves part of issue #984.

@zbeach
"visitor" pattern: Use local variable type inference
b12fd7e 
Update "visitor" pattern with local variable type inference.
@zbeach
"value-object" pattern: Use local variable type inference
40c26aa 
Update "value-object" pattern with local variable type inference.
@zbeach
"unit-of-work" pattern: Use local variable type inference
d12bdd6 
Update "value-object" pattern with local variable type inference.
@zbeach
"typeobjectpattern" pattern: Use local variable type inference
604caf7 
Update "value-object" pattern with local variable type inference.
@iluwatar iluwatar self-assigned this Oct 13, 2019
iluwatar
iluwatar requested changes Oct 13, 2019
View reviewed changes
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis builds shows an error related to jacoco. Although it may that the error is not related to this PR. See the attached image

image

@iluwatar
Copy link
Owner

@zbeach please resolve the conflict and merge master

@iluwatar iluwatar merged commit c81c3ff into iluwatar:master Oct 21, 2019
@iluwatar
Copy link
Owner

Thank you for the contribution @zbeach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar approved these changes

Assignees

@iluwatar iluwatar

Labels
status: under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zbeach @iluwatar