-
-
Notifications
You must be signed in to change notification settings - Fork 26.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Video.toString() output illegal json and refactor #3032
Conversation
|
||
Assertions.assertEquals(expectedDetails, actualFieldsDetails); | ||
} | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an extra line at EOF to satisfy github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the commits
refactor: json string concat add an extra line at EOF
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks good! Thank you for the contribution 🎉 |
@all-contributors please add @Xcyq for code |
I've put up a pull request to add @Xcyq! 🎉 |
@all-contributors please add @Ritabrata1080 for review |
I've put up a pull request to add @Ritabrata1080! 🎉 |
What problem does this PR solve?