Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finished Explanation for Leader/Followers #2239 #2733

Merged
merged 6 commits into from
Mar 17, 2024
Merged

Finished Explanation for Leader/Followers #2239 #2733

merged 6 commits into from
Mar 17, 2024

Conversation

Jack-Hodges
Copy link
Contributor

Added explanation for issue #2239 which consisted of adding intent, explanation, programmatic example, as well as applications and consequences.

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stale Stale
Copy link

stale bot commented Nov 24, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Nov 24, 2023
iluwatar
iluwatar requested changes Dec 27, 2023
View reviewed changes
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well written, but the explanation is disconnected from the actual code example that we have in the repository. Could you update it so that the explanation is based on the code?

@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Dec 27, 2023
@stale Stale
Copy link

stale bot commented Jan 26, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Jan 26, 2024
@stale Stale
Copy link

stale bot commented Mar 12, 2024

Closed due to inactivity. Thank you for your contributions.

@stale stale bot closed this Mar 12, 2024
@iluwatar iluwatar reopened this Mar 17, 2024
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Mar 17, 2024
@iluwatar iluwatar merged commit c7c0828 into iluwatar:master Mar 17, 2024
2 checks passed
@iluwatar
Copy link
Owner

Looks good! Thank you for the contribution 🎉

@all-contributors please add @JackH408 for docs

@allcontributors AllContributors
Copy link
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@JackH408 already contributed before to doc

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar approved these changes

Assignees
No one assigned
Labels
status: under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jack-Hodges @iluwatar