#2681 : add messaging design pattern implementation with kafka #2712
Conversation
messaging/src/main/java/com/iluwatar/messaging/MessagingApplication.java
Show resolved
Hide resolved
messaging/src/main/java/com/iluwatar/messaging/model/MenuItemIdAndQuantity.java
Outdated
Show resolved
Hide resolved
messaging/src/test/java/com/iluwatar/messaging/MessagingApplicationTests.java
Outdated
Show resolved
Hide resolved
messaging/src/test/java/com/iluwatar/messaging/controller/OrderControllerIntegrationTest.java
Outdated
Show resolved
Hide resolved
messaging/src/test/java/com/iluwatar/messaging/controller/OrderControllerIntegrationTest.java
Show resolved
Hide resolved
-- refactoring source, test -- clean up in pom file -- updated comments in source -- refactoring the readme wiki
|
Kudos, SonarCloud Quality Gate passed!
|
|
@iluwatar please check the resolved commit as per your feedback |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
status: stale
|
Closed due to inactivity. Thank you for your contributions. |
stale
bot
removed
the
status: stale
|
|
||
| ### Credits: | ||
| ``` Chris Richardson ``` | ||
| Experienced software architect, author of POJOs in Action, the creator of the original CloudFoundry.com |
There was a problem hiding this comment.
Readme should follow the pattern template. See here: https://github.com/iluwatar/java-design-patterns/wiki/02.-Pattern-template Check out also the other design pattern readmes for examples.
| $MAVEN_DEBUG_OPTS \ | ||
| -classpath "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.jar" \ | ||
| "-Dmaven.multiModuleProjectDirectory=${MAVEN_PROJECTBASEDIR}" \ | ||
| ${WRAPPER_LAUNCHER} $MAVEN_CONFIG "$@" |
There was a problem hiding this comment.
not needed, maven wrapper resides on the parent level
|
|
||
| if "%MAVEN_TERMINATE_CMD%"=="on" exit %ERROR_CODE% | ||
|
|
||
| cmd /C exit /B %ERROR_CODE% |
There was a problem hiding this comment.
not needed, maven wrapper resides on the parent level
| <plugin> | ||
| <groupId>com.iluwatar.urm</groupId> | ||
| <artifactId>urm-maven-plugin</artifactId> | ||
| <version>2.1.1</version> | ||
| <configuration> | ||
| <!-- if outputDirectory is not set explicitly it will default to your build dir --> | ||
| <outputDirectory>${project.basedir}/etc</outputDirectory> | ||
| <packages> | ||
| <param>com.iluwatar.messaging</param> | ||
| </packages> | ||
| <includeMainDirectory>true</includeMainDirectory> | ||
| <includeTestDirectory>false</includeTestDirectory> | ||
| <presenter>graphviz</presenter> | ||
| </configuration> | ||
| <executions> | ||
| <execution> | ||
| <phase>process-classes</phase> | ||
| <goals> | ||
| <goal>map</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| </build> |
There was a problem hiding this comment.
This config is not needed here. The plugin is already configured on the parent level.
|
|
||
| @Getter | ||
| @Setter | ||
| public class MenuItemIdAndQuantity { |
There was a problem hiding this comment.
Consider using record
https://www.baeldung.com/java-record-keyword
|
|
||
| import java.util.List; | ||
|
|
||
| public class Order { |
There was a problem hiding this comment.
Lot of boilerplate code here. Consider using Lombok's getter, setter, etc.
|
|
||
| import java.util.List; | ||
|
|
||
| public class OrderRequest { |
There was a problem hiding this comment.
Lot of boilerplate code here. Consider using Lombok's getter, setter, etc.
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
status: stale
|
Closed due to inactivity. Thank you for your contributions. |
Pull request title
Pull request description