Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1316 Single Table Inheritance pattern implemented #2632

Merged
merged 13 commits into from
Feb 25, 2024
Merged

#1316 Single Table Inheritance pattern implemented #2632

merged 13 commits into from
Feb 25, 2024

Conversation

ved-asole
Copy link
Contributor

Pull request title

Pull request description

For detailed contributing instructions see https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

@ved-asole
Copy link
Contributor Author

ved-asole commented Oct 10, 2023 •
edited
Loading

Hi @iluwatar, the code is running in my system but not sure why it is not working with the checks.. Could you please assist me to resolve this issue?

image

@ved-asole
Copy link
Contributor Author

Hi @iluwatar, could you please check and confirm if any changes are required?

@ved-asole
Copy link
Contributor Author

Hi @iluwatar, could you please review the above pull request

iluwatar
iluwatar requested changes Oct 25, 2023
View reviewed changes
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few minor remarks. Also, please resolve the conflicts.

pom.xml Show resolved Hide resolved
single-table-inheritance/pom.xml Outdated Show resolved Hide resolved
single-table-inheritance/src/main/java/com/iluwatar/SingleTableInheritance.java Outdated Show resolved Hide resolved
single-table-inheritance/src/main/java/com/iluwatar/entity/TransportVehicle.java Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

3.4% 3.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ved-asole
Copy link
Contributor Author

Hi @iluwatar, I have updated the code as per the review. Please approve the merge request.

@ved-asole
Copy link
Contributor Author

Hi @iluwatar , I have updated the code as per the review. Please approve the merge request.

@ved-asole
Copy link
Contributor Author

Hi @iluwatar, please review the above PR. I have made the necessary changes after the review.

@ved-asole
Copy link
Contributor Author

Hi @iluwatar, could you please approve the change request?

@ved-asole
Copy link
Contributor Author

Hi @iluwatar , request you to please assist and approver the above PR

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 17, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@stale Stale
Copy link

stale bot commented Jan 17, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Jan 17, 2024
@ved-asole
Copy link
Contributor Author

@iluwatar , could you please review and approve the PR?

@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Jan 17, 2024
@ved-asole ved-asole mentioned this pull request Jan 25, 2024
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@ved-asole
Copy link
Contributor Author

Hi @iluwatar , please approve the PR. I have resolved the merge conflicts

@stale Stale
Copy link

stale bot commented Feb 24, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Feb 24, 2024
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Feb 25, 2024
@iluwatar iluwatar merged commit b2c7410 into iluwatar:master Feb 25, 2024
1 check passed
@iluwatar
Copy link
Owner

Looks good! Thank you for the contribution 🎉

@all-contributors please add @ved-asole for code

@allcontributors allcontributors bot mentioned this pull request Feb 25, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @ved-asole! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar approved these changes

Assignees
No one assigned
Labels
status: under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ved-asole @iluwatar