Add CRTP pattern Ref: #2342 #2580
Conversation
crtp/README.md
Outdated
| --- | ||
| title: Curiously Recurring Template Pattern | ||
| language: en | ||
| --- |
There was a problem hiding this comment.
check out the required yaml frontmatter at https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute
There was a problem hiding this comment.
I've updated the frontmatter adding category and tag fields
| * | ||
| * @param <T> MmaFighter derived class that uses itself as type parameter. | ||
| */ | ||
| @Slf4j |
There was a problem hiding this comment.
Check out for what else you can use Lombok for e.g. generate constructor, toString etc.
There was a problem hiding this comment.
I replaced the constructor and toString() in MmaFighter with @DaTa annotation
| @Test | ||
| void shouldExecuteApplicationWithoutException() { | ||
| assertDoesNotThrow(() -> App.main(new String[]{})); | ||
| } |
There was a problem hiding this comment.
This is the only test? I think it's not sufficient.
There was a problem hiding this comment.
There's a new test in FightTest.java file
|
Kudos, SonarCloud Quality Gate passed!
|
|
Looks good! Thank you for the contribution 🎉 @all-contributors please add @AddeusExMachina for code |
|
I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @AddeusExMachina! 🎉 |
Add crtp directory containing source code and documentation for the curiously recurring template pattern