Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor monitor patterns example code #2560

Merged
merged 3 commits into from
Aug 20, 2023
Merged

Conversation

bakazhou
Copy link
Contributor

@bakazhou bakazhou commented Aug 8, 2023

Refactor

  • Refactoring the code in monitor pattern that is not reasonable enough

Pull request description

  • Modify amount random value origin and bound
  • Add getBalance method in Bank class
  • Add test for new getBalance method
  • Some constants are extracted

It is my first pull request
Have a nice day😁

@sonatype-lift
Copy link

sonatype-lift bot commented Aug 8, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.7% 72.7% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@iluwatar iluwatar merged commit 24090e4 into iluwatar:master Aug 20, 2023
2 checks passed
@iluwatar
Copy link
Owner

Looks good! Thank you for the contribution 🎉

@all-contributors please add @bakazhou for code

@allcontributors
Copy link
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @bakazhou! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants