Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Layered Architecture pattern #2936

Closed
iluwatar opened this issue May 4, 2024 · 1 comment
Closed

Refactor Layered Architecture pattern #2936

iluwatar opened this issue May 4, 2024 · 1 comment
Assignees
@romannimets
Labels
epic: pattern type: refactoring

Comments

@iluwatar
Copy link
Owner

iluwatar commented May 4, 2024

A couple of specific refactorings are needed for Layered Architecture code example.

  • Runner.java has no main entry point and can't be executed in the IDE. Let's add this.
  • 3 Warnings: Optional used as type for field id. This is related to classes CakeInfo, CakeLayerInfo, and CakeToppingInfo.

Optional is primarily intended for use as a method return type where there is a clear need to represent "no result," and where using null is likely to cause errors.

Acceptance criteria

  • Refactorings implemented
@iluwatar iluwatar converted this from a draft issue May 4, 2024
romannimets added a commit to romannimets/java-design-patterns that referenced this issue May 5, 2024
@romannimets
fix: Refactor Layered Architecture pattern iluwatar#2936
773832a
romannimets added a commit to romannimets/java-design-patterns that referenced this issue May 5, 2024
@romannimets
Revert "fix: Refactor Layered Architecture pattern iluwatar#2936"
54aee49 
This reverts commit 773832a.
romannimets added a commit to romannimets/java-design-patterns that referenced this issue May 5, 2024
@romannimets
Reapply "fix: Refactor Layered Architecture pattern iluwatar#2936"
0d19c7a 
This reverts commit 54aee49.
@romannimets
Copy link
Contributor

Hey! I would like to contribute to this issue

@romannimets romannimets mentioned this issue May 5, 2024
Merged
@iluwatar iluwatar moved this from Todo to In Progress in Java Design Patterns project May 6, 2024
@iluwatar iluwatar mentioned this issue Jun 6, 2024
Closed
iluwatar pushed a commit that referenced this issue Jun 15, 2024
@romannimets
refactor: Refactor Layered Architecture pattern #2936 (#2938)
a27e092
@github-project-automation github-project-automation bot moved this from In Progress to Done in Java Design Patterns project Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romannimets romannimets

Labels
epic: pattern type: refactoring
Projects
Java Design Patterns project
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iluwatar @romannimets