Executable jar problem

[iluwatar]

The project includes Maven Assembly plugin to produce executable jars out of all the submodules (individual patterns). However, there currently seems to be a problem with the intended behaviour.

Steps to reproduce:

1. At the project root build everything, i.e. mvn clean package -DskipTests=true
2. Execute one of the produced jars, e.g. java -jar spatial-partition/target/spatial-partition-1.26.0-SNAPSHOT.jar

Expected behaviour

• The spatial partition jar is executed and the pattern example runs without problems

Actual behavior

• An error message no main manifest attribute, in spatial-partition/target/spatial-partition-1.26.0-SNAPSHOT.jar is printed

[satyajitbhatt]

Hello @iluwatar Can you give me chance to solve above issue ? If yes then I'm willing to contribute over here and want to help you to solve executable jar problem.

Thank you in advance

[Sujoydas001]

Can I have a look here ?

[iluwatar]

@satyajitbhatt are you working on it?

[satyajitbhatt]

No, I am not.

…

On Sun, Sep 24, 2023, 8:49 PM Ilkka Seppälä ***@***.***> wrote: @satyajitbhatt <https://github.com/satyajitbhatt> are you working on it? — Reply to this email directly, view it on GitHub <#2565 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQA37LBSGJBBQPEG7M7L453X4BFPXANCNFSM6AAAAAA3XDA7MQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Navneetsinghnegi]

@iluwatar I want to go through the issue and work upon it

[BrijeshPatra]

Hi @iluwatar here we have 2 approaches to solve this bug
a) add the name of main class to the jar file
b) create the jar file as an executable jar

[BrijeshPatra]

I am trying hard to contribute but getting an error Unable to access jarfile spatial-partition/target/spatial-partition-1.26.0-SNAPSHOT.jar. It would be helpful if you review it once and suggest me something better @iluwatar

[BrijeshPatra]

[iluwatar]

Assigned to @Navneetsinghnegi

[Aniket-kumar404]

I would Like to work on this issue.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions.

[emcconnell27]

Hi @iluwatar, could please have a go at solving this issue?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions.

[apophizzz]

Hi @iluwatar, I think I actually found a tiny configuration fix for the assembly plugin that produces a single fat JAR - e.g. proxy-1.26.0-SNAPSHOT.jar - which executes successfully:

$ cd proxy/
$ mvn clean package -DskipTests=true 
$ ls -al target/
-rw-r--r--   1 patrick  staff  958950 Oct  8 00:12 proxy-1.26.0-SNAPSHOT.jar
...
$ java -jar target/proxy-1.26.0-SNAPSHOT.jar
00:12:39.160 [main] INFO com.iluwatar.proxy.IvoryTower -- Red wizard enters the tower.
00:12:39.162 [main] INFO com.iluwatar.proxy.IvoryTower -- White wizard enters the tower.
00:12:39.163 [main] INFO com.iluwatar.proxy.IvoryTower -- Black wizard enters the tower.
00:12:39.163 [main] INFO com.iluwatar.proxy.WizardTowerProxy -- Green wizard is not allowed to enter!
00:12:39.163 [main] INFO com.iluwatar.proxy.WizardTowerProxy -- Brown wizard is not allowed to enter!

Feel free to assign the issue to me and I'll submit a PR. Thx!

[ananyadhagat]

Hey I am working on this issue @iluwatar

[Soumayadip937]

@iluwatar I am new to open source contribution, could you please help me to get started on this issue?

[yuvraj-kumar-dev]

Hi @iluwatar,
I'd love to tackle the Maven Assembly plugin issue. Could you please assign this task to me?
Thank you!

[abhi8f]

Hi @iluwatar

there is two jar files spatial-partition-1.26.0-SNAPSHOT.jar and spatial-partition.jar
is 2 jar files intended behavior ? if no i have soultion

if only one jar file is required, putting filename in maven assembly plugin works
i can do this and raise a pull request