-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Snippet to Rename a File #225
Conversation
|
||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an extra line at EOF to satisfy github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash all the commits into a single commit.
Changes to add EOF
@@ -0,0 +1,44 @@ | |||
package file; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Check the other files and update the file header please.
- Also squash all the commits.
- Just add 1 empty line at the EOF instead of adding multiple lines. Also no need to write anything in the empty line, it will defeat the purpose of empty line addition. I can see you have written "//EOF" which is flawed.
With these changes, the PR looks good to me.
Code snippet which can customize the file names by taking user input or using command-line arguments.