Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codegen (#1) #3

Closed
wants to merge 15 commits into from
Closed

Fix codegen (#1) #3

wants to merge 15 commits into from

Conversation

ilslv
Copy link
Owner

@ilslv ilslv commented Jul 29, 2021

Part of #1

Synopsis

Fix cucumber_rust_codegen to work with redesign. Also fix some bugs of initial implementation.

Solution

  • Fix cucumber_rust_codegen;
  • Update docs;
  • Fix bug, which required step attribute to be the last one.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added enhancement New feature or request k::design Related to overall design and/or architecture k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels Jul 29, 2021
@ilslv ilslv self-assigned this Jul 29, 2021
@ilslv ilslv marked this pull request as draft July 29, 2021 10:05
@ilslv ilslv closed this Jul 30, 2021
@ilslv
Copy link
Owner Author

ilslv commented Jul 30, 2021

Closing due merge into #2

@ilslv ilslv deleted the fix-codegen branch July 30, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ilslv ilslv

Labels
enhancement New feature or request k::design Related to overall design and/or architecture k::refactor Refactoring, technical debt elimination and other improvements of existing code base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ilslv