Handle optional attributes as non-optional if they have default values #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call schema.AttributeIsOptional instead of directly IsOptional. Rename AttributeMode types to clarify that they are specific to resource attributes, and not datasource attributes.
Float32ResourceAttributeWithMode Int32ResourceAttributeWithMode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix how attributes are determined to be optional.
Implement the
AttributeIsOptionalfunction to decide whether an attribute is optional: an attribute is now considered optional only if it hasOptionalset totrueand it has noDefaultvalue.Call
AttributeIsOptionalinstead of directlyIsOptionalin all code generators.Rename
AttributeModetypes to clarify that they specify to resource attributes, and not datasource attributes.Define missing types for attributes with mode:
Float32ResourceAttributeWithMode,Int32ResourceAttributeWithMode.Regenerate the code.
Verified that optional fields with defaults are never set to
Null.