Submodule to onboard AWS account #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlenglet
requested changes
Sep 30, 2024
rlenglet
reviewed
Sep 30, 2024
rlenglet
requested changes
Oct 2, 2024
rlenglet
changed the title
rlenglet
reviewed
Oct 2, 2024
rlenglet
reviewed
Oct 2, 2024
rlenglet
reviewed
Oct 2, 2024
rlenglet
reviewed
Oct 2, 2024
Remove outdated example. List the new `aws_account` module.
|
@evanj80-illumio can you please take a look at this? I fixed a few things in the |
|
@itsesterline can you please take a look at this? Esp. the docs & examples. |
|
No comments on any of the TF changes just some on the GHA and readme |
rlenglet
previously approved these changes
Oct 2, 2024
evanj80-illumio
previously approved these changes
Oct 2, 2024
rlenglet
reviewed
Oct 2, 2024
rlenglet
dismissed stale reviews from evanj80-illumio and themself
via
7fce273
rlenglet
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add aws_account nested module which defines an AWS IAM role and policies to allow Illumio CloudSecure's AWS account to read/write an AWS account's resources and onboard that AWS account with CloudSecure.
Simplify the example for each module.
Update GitHub action to regenerate docs for examples.