Add aws_flow_logs_s3_buckets module #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
shireesh-illumio
requested changes
Oct 4, 2024
There was a problem hiding this comment.
also can we modify the random_uuid to random_password as in #10
makes module secure.
Good idea. Done! |
shireesh-illumio
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
aws_flow_logs_s3_bucketssubmodule.In
aws_account, replace the usage ofrandom_uuidwithrandom_passwordto increase the strength of the role external ID.Improve formatting and structure of examples.
Delete empty
outputs.tffiles.Fix the validation of variables in
aws_accountexample.Set version to v1.2.0.