[10.x] Fix Accepting nullable Parameters, updated doc block, and null…

… pointer exception handling in batchable trait (#50209) * fix(Reachable Trait): fix parameters type and doc block in With withFakeBatch method * fix(Reachable Trait): fix null pointer exception * fix(Batchable Trait): fix parameters type and doc block in With withFakeBatch method * fix(Batchable Trait): fix null pointer exception * Update Batchable.php --------- Co-authored-by: Taylor Otwell <[email protected]>
illuminate · Feb 23, 2024 · 33993b8 · 33993b8
1 parent 1996308
commit 33993b8
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/Batchable.php b/Batchable.php
@@ -35,7 +35,7 @@ public function batch()
         }
 
         if ($this->batchId) {
-            return Container::getInstance()->make(BatchRepository::class)->find($this->batchId);
+            return Container::getInstance()->make(BatchRepository::class)?->find($this->batchId);
         }
     }
 
@@ -74,7 +74,7 @@ public function withBatchId(string $batchId)
      * @param  int  $failedJobs
      * @param  array  $failedJobIds
      * @param  array  $options
-     * @param  \Carbon\CarbonImmutable  $createdAt
+     * @param  \Carbon\CarbonImmutable|null  $createdAt
      * @param  \Carbon\CarbonImmutable|null  $cancelledAt
      * @param  \Carbon\CarbonImmutable|null  $finishedAt
      * @return array{0: $this, 1: \Illuminate\Support\Testing\Fakes\BatchFake}
@@ -86,7 +86,7 @@ public function withFakeBatch(string $id = '',
                                   int $failedJobs = 0,
                                   array $failedJobIds = [],
                                   array $options = [],
-                                  CarbonImmutable $createdAt = null,
+                                  ?CarbonImmutable $createdAt = null,
                                   ?CarbonImmutable $cancelledAt = null,
                                   ?CarbonImmutable $finishedAt = null)
     {