Add Docker support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmcguire81, we need to add the |
dmcguire81
reviewed
Nov 24, 2022
| RUN mkdir build | ||
|
|
||
| WORKDIR /metapy | ||
| RUN sed -i 's:add_subdirectory(deps/meta EXCLUDE_FROM_ALL):find_package(MeTA 3.0.2 REQUIRED):g' CMakeLists.txt |
There was a problem hiding this comment.
So this just builds the pybind11 code and not the dependencies?
There was a problem hiding this comment.
Yes, MeTA and its dependencies are already built as libraries.
dmcguire81
approved these changes
Nov 24, 2022
dmcguire81
reviewed
Nov 24, 2022
Dockerfile
Outdated
| python3-pip | ||
|
|
||
| WORKDIR /metapy | ||
| RUN git submodule update --init --recursive |
There was a problem hiding this comment.
Docker build fails here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a Dockerfile that extends the MeTA Docker image to install metapy. Users can use the Dockerfile or the Docker image built from it to run Python programs that require metapy.