Update types.d.ts #315
Merged
Update types.d.ts #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the config `strict: true`, typescript cannot build vue-cool-select. I added very basic typings to prevent that.
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 92.48% 92.48%
=======================================
Files 9 9
Lines 306 306
Branches 91 90 -1
=======================================
Hits 283 283
Misses 21 21
Partials 2 2Continue to review full report at Codecov.
|
iliyaZelenko
added a commit
that referenced
this pull request
Feb 4, 2020
When using the config strict: true, typescript cannot build vue-cool-select. Added very basic typings to prevent that. Re #315
|
🎉 This PR is included in version 3.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks! |
rin4573281133639
added a commit
to rin4573281133639/iliyaZelenko9
that referenced
this pull request
Feb 5, 2022
## [3.5.2](iliyaZelenko/vue-cool-select@v3.5.1...v3.5.2) (2020-02-04) ### Bug Fixes * pin core-js to 3.4.6 ([081a676](iliyaZelenko/vue-cool-select@081a676)) * **types:** incorrect work with config strict: true ([0f1d2f8](iliyaZelenko/vue-cool-select@0f1d2f8)), closes [#315](iliyaZelenko/vue-cool-select#315) * **types:** incorrect work with config strict: true ([8fbb9a5](iliyaZelenko/vue-cool-select@8fbb9a5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the config
strict: true, typescript cannot build vue-cool-select.I added very basic typings to prevent that.