-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(volume_rate): Add cubic_meter_per_min and cubic_meter_per_hour as volume rate units #406
Conversation
Waiting on #405 before marking this as ready for review.a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Changes look pretty good. Two minor changes below.
Thants for the suggestions, implemented those. :) |
Similar to the other PR can you squash the commits and update the commit message. At the same time you can exclude the mass rate changes and just base this on top of iliekturles/master. I'm definitely open to STP contributions. |
well, what I ideally would want is to have a general support of STP wherever it could apply, as well as adding methods to convert from/into other units. I'll have to take a look at how |
…ubic_meter_per_hour
Everything should be ready now. |
Thanks for the PR! |
This PR attempts to add cubic_meter_per_min and cubic_meter_per_hour as volume rate units.