Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add action quantity with corresponding units and tests. #325

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Add action quantity with corresponding units and tests. #325

merged 1 commit into from
Oct 26, 2022

Conversation

crystal-growth
Copy link
Contributor

@crystal-growth crystal-growth commented Aug 3, 2022 •
edited
Loading

Adding quantity for Action [Energy x Time] with units:

  • joule second
  • erg second
  • eV second
  • reduced Planck constant as an atomic unit of action
  • "normal" Planck constant

@crystal-growth crystal-growth force-pushed the add_action branch 2 times, most recently from 358040e to ae22375 Compare August 12, 2022 07:42
iliekturtles
iliekturtles requested changes Aug 17, 2022
View reviewed changes
Copy link
Owner

@iliekturtles iliekturtles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't end up finishing this review.

src/si/action.rs Outdated Show resolved Hide resolved
src/si/action.rs Outdated Show resolved Hide resolved
@iliekturtles iliekturtles merged commit f187efa into iliekturtles:master Oct 26, 2022
@iliekturtles
Copy link
Owner

Thanks for the PR and sorry for delays. I thought I was going to get to these a month ago!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliekturtles iliekturtles iliekturtles requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crystal-growth @iliekturtles