Added prefixes for electronvolt (eV) #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliekturtles
reviewed
Aug 6, 2020
src/si/energy.rs
Outdated
Comment on lines
50
to
57
| @petaelectronvolt: 1.602_177_E-4; "PeV", "petaelectronvolt", "petaelectronvolts"; | ||
| @teraelectronvolt: 1.602_177_E-7; "TeV", "teraelectronvolt", "teraelectronvolts"; | ||
| @gigaelectronvolt: 1.602_177_E-10; "GeV", "gigaelectronvolt", "gigaelectronvolts"; | ||
| @megaelectronvolt: 1.602_177_E-13; "MeV", "megaelectronvolt", "megaelectronvolts"; | ||
| @kiloelectronvolt: 1.602_177_E-16; "KeV", "kiloelectronvolt", "kiloelectronvolts"; | ||
| @hectoelectronvolt: 1.602_177_E-17; "heV", "hectoelectronvolt", "hectoelectronvolts"; | ||
| @decaelectronvolt: 1.602_177_E-18; "daeV", "decaelectronvolt", "decaelectronvolts"; | ||
| @electronvolt: 1.602_177_E-19; "eV", "electronvolt", "electronvolts"; |
There was a problem hiding this comment.
- Can you adjust the conversion factor for
electronvoltto1.602_176_634_E-19and adjust the other units accordingly (https://physics.nist.gov/cgi-bin/cuu/CCValue?evj|ShowSecond=electronvolt&First=hev). This more exact value may come from the recent 2019 SI redefinition. - Correct the
kiloelectronvoltabbreviation tokeV.
There was a problem hiding this comment.
Sorry for late response. Fixed the conversion factor and KeV -> keV.
|
Mind squashing the commits together? I'll merge after that. |
Updated electronvolt definition, fixed KeV -> keV.
|
Merged! Thanks so much for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know the policy of which units gets prefixes but I needed kiloelectronvolt (KeV) so why not.