Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum supported rustc version to 1.28.0. #148

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Conversation

iliekturtles
Copy link
Owner

Changed in anticipation of adding #[repr(transparent)] in #145.
Zero-cost codegen note regarding rustc 1.25.0 is now no longer
relevant.

@iliekturtles
Copy link
Owner Author

Build failing for 1.28.0 with the following error:

error: failed to parse manifest at `D:\Code\Test\rust\uom\uom-macros\Cargo.toml`

Caused by:
  editions are unstable

Caused by:
  feature `edition` is required

this Cargo does not support nightly features, but if you
switch to nightly channel you can add
`cargo-features = ["edition"]` to enable this feature

edition keyword is now recognized by cargo but not yet stabilized. Previously builds for 1.24.1 would still pass because the edition keyword was not recognized and hence ignored by cargo. May need to do a 1.28.0 / 1.31.0 split.

@iliekturtles iliekturtles force-pushed the dev-rustc branch 4 times, most recently from 8eb92bb to 6001078 Compare June 16, 2019 12:59
Changed in anticipation of adding `#[repr(transparent)]` in #145.
Zero-cost codegen note regarding `rustc` 1.25.0 is now no longer
relevant.
@iliekturtles iliekturtles merged commit cd9223d into master Jun 17, 2019
@iliekturtles iliekturtles deleted the dev-rustc branch June 17, 2019 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant