Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for i128/u128 #85

Closed
iliekturtles opened this issue May 10, 2018 · 4 comments
Closed

Add support for i128/u128 #85

iliekturtles opened this issue May 10, 2018 · 4 comments

Comments

@iliekturtles
Copy link
Owner

Add support for i128/u128 now that both types are stable. This may be blocked by the num-* crates which may not support these types. Leave types out of CI build scripts for the moment. A larger effort to better support different rustc versions will need to be done.

@iliekturtles
Copy link
Owner Author

Consider adding a build script to detect the rustc version and remove the manual version numbers. This can also be used to control i128/u128 features.

https://www.reddit.com/r/rust/comments/8ioqyk/how_should_a_library_support_u128/

@Aehmlo
Copy link
Contributor

Aehmlo commented May 15, 2018

I think we should be good on the other crates.

@Aehmlo
Copy link
Contributor

Aehmlo commented Jun 19, 2019

I think this is was what I was thinking of in #150, for what it's worth.

@iliekturtles
Copy link
Owner Author

i128/u128 were stabilized in 1.26.0. Now that uom requires 1.28.0 these can be added without any version checking!

iliekturtles added a commit that referenced this issue Jun 24, 2019
iliekturtles added a commit that referenced this issue Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants