Fix sumif PHPOffice#683

ilicmsreten · Oct 2, 2018 · df7c61a · df7c61a
1 parent 57404f4
commit df7c61a
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/PhpSpreadsheet/Calculation/Functions.php b/src/PhpSpreadsheet/Calculation/Functions.php
@@ -267,7 +267,7 @@ public static function isCellValue($idx)
     public static function ifCondition($condition)
     {
         $condition = self::flattenSingleValue($condition);
-        if (!isset($condition[0])) {
+        if (!isset($condition[0]) && !is_numeric($condition)) {
             $condition = '=""';
         }
         if (!in_array($condition[0], ['>', '<', '='])) {

diff --git a/tests/data/Calculation/MathTrig/SUMIF.php b/tests/data/Calculation/MathTrig/SUMIF.php
@@ -58,4 +58,28 @@
             [100],
         ],
     ],
+    [
+        100,
+        [
+            ['0'],
+            ['some text'],
+        ],
+        0, // Compare integer with string
+        [
+            [100],
+            [1],
+        ],
+    ],
+    [
+        100,
+        [
+            [0],
+            ['some text'],
+        ],
+        0, // Compare integer with integer
+        [
+            [100],
+            [1],
+        ],
+    ],
 ];