This repository has been archived by the owner on Sep 28, 2019. It is now read-only.
flash/nor/stm32h7x: fix flash write enable bug. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bank x internal buffer control bit (PGx) needs to be set to enable write operations before flashing an H7x part. The stm32x_write function does this in its "standard programming" fallback loop and a branch for handling remaining bytes, but never sets PGx prior to calling stm32x_write_block. For some reason, the existing code still succeeds on rev Y silicon, but fails on rev V parts. This commit sets the PGx bit prior to calling stm32x_write_block.
|
The corresponding issue may be found here: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bank x internal buffer control bit (PGx) needs to be set to enable
write operations before flashing an H7x part. The stm32x_write function
does this in its "standard programming" fallback loop and a branch for
handling remaining bytes, but never sets PGx prior to calling
stm32x_write_block. For some reason, the existing code still succeeds on
rev Y silicon, but fails on rev V parts.
This commit sets the PGx bit prior to calling stm32x_write_block.