Skip to content
This repository has been archived by the owner on Sep 28, 2019. It is now read-only.

shard work #11

Closed
fatalfeel opened this issue Mar 12, 2017 · 1 comment
Closed

shard work #11

fatalfeel opened this issue Mar 12, 2017 · 1 comment
Labels
invalid

Comments

@fatalfeel
Copy link

openocd full debug in uboot and kernel
http://fatalfeel.blogspot.tw/2015/12/openocd-with-eclipse-debug-kernel-of.html
@ilg-ul
Copy link
Contributor

ilg-ul commented Mar 12, 2017

is this a bug report?

ilg-ul pushed a commit that referenced this issue Jun 5, 2017
@timsifive
Merge pull request #11 from sifive/malloc_off_by_1
193f630 
Correct off by 1 in malloc
@ilg-ul ilg-ul added the invalid label Sep 25, 2017
@ilg-ul ilg-ul closed this as completed Sep 25, 2017
ilg-ul pushed a commit that referenced this issue May 12, 2018
@tom-van
helper/types: cast to uint32_t,uint16_t to avoid UB by shifting int t…
d4ef54c 
…oo far

Without this, we have some types promoted to `int` when they need to be
`unsigned int`.

Here's some ubsan output hitting this:

Unfortunately, what happens is that things get promoted to `int`, but
need to be `unsigned int`. Here's the ubsan output:

src/helper/types.h:126:65: runtime error: left shift of 255 by 24 places cannot be represented in type 'int'
    #0 0x55978a612060 in le_to_h_u32 src/helper/types.h:126
    #1 0x55978a61ff9e in stlink_usb_read_reg src/jtag/drivers/stlink_usb.c:1539
    #2 0x55978a8cfd45 in adapter_load_core_reg_u32 src/target/hla_target.c:67
    #3 0x55978a9f48e3 in armv7m_read_core_reg src/target/armv7m.c:236
    #4 0x55978a8d24fc in adapter_load_context src/target/hla_target.c:372
    #5 0x55978a8d261b in adapter_debug_entry src/target/hla_target.c:396
    #6 0x55978a8d3123 in adapter_poll src/target/hla_target.c:457
    #7 0x55978a528357 in target_poll src/target/target.c:535
    #8 0x55978a539fd4 in target_wait_state src/target/target.c:2914
    #9 0x55978a556e20 in jim_target_wait_state src/target/target.c:5256
    #10 0x55978a5cca62 in command_unknown src/helper/command.c:1030
    #11 0x55978aaed894 in JimInvokeCommand /home/cody/d/openocd-code/jimtcl/jim.c:10364

Change-Id: I24f6abfd26b6980100657397d69c84f2b80a005a
Signed-off-by: Cody P Schafer <[email protected]>
Reviewed-on: http://openocd.zylin.com/4455
Reviewed-by: Tomas Vanek <[email protected]>
Tested-by: jenkins
Reviewed-by: Christopher Head <[email protected]>
@faisal-shah faisal-shah mentioned this issue Jun 14, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilg-ul @fatalfeel